sync RPSaaSMaster branch to main branch #17166
Conversation
|
Hi, @PingZhu2232 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi, @PingZhu2232 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.FluidRelay/preview/2021-09-10-preview/fluidrelay.json#L598 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.FluidRelay/preview/2021-08-30-preview/fluidrelay.json#L595 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 50 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:preview/2021-08-30-preview/fluidrelay.json compared with base:preview/2021-06-15-preview/fluidrelay.json
- current:preview/2021-09-10-preview/fluidrelay.json compared with base:preview/2021-06-15-preview/fluidrelay.json
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Swagger Generation Artifacts
|
|
Hi @PingZhu2232, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
This PR is to add 2 new API versions which are already in RPSaaSMaster branch and we have been using it in production environment. Commit history in RPSaaSMaster: https://github.com/Azure/azure-rest-api-specs-pr/commits/RPSaaSMaster/specification/fluidrelay/resource-manager/Microsoft.FluidRelay/preview And this PR is to catch up the latest 4 PR in RPSaaSMaster which have ARM signoff already: |
raosuhas
added
ARMSignedOff
|
Hi @PingZhu2232, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@chunyu3 The breaking changes are all "x-ms-client-request-id" and "x-ms-correlation-request-id". They are not required in the response. We are in public preview right now and a few customers are using our RP via Azure portal but none of them are looking for the 2 headers in the response. So we wanted to remove them in swagger for easier development. |
The breaking change review still need. |
JeffreyRichter
added
the
Approved-BreakingChange
* copy previous version * changes to 08-30 version * copy previous version * changes to 09-10 version * add reference * revert 06-15 to have headers * fix typo * typo Co-authored-by: Ping Zhu <pizh@Pings-MacBook-Pro.local>
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.FluidRelay/fluidRelayServers/{fluidRelayServerName}/fluidRelayContainers/{fluidRelayContainerName}": { |
* copy previous version * changes to 08-30 version * copy previous version * changes to 09-10 version * add reference * revert 06-15 to have headers * fix typo * typo Co-authored-by: Ping Zhu <pizh@Pings-MacBook-Pro.local>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.